Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smartmobile link generation #12

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix smartmobile link generation #12

merged 1 commit into from
Mar 28, 2024

Conversation

midahp
Copy link
Contributor

@midahp midahp commented Mar 25, 2024

fixes a no such method error introduced because of the removal of __getParameters in horde/url here

@midahp
Copy link
Contributor Author

midahp commented Mar 25, 2024

@ralflang Tests fail, but they already did e.g. in https://github.com/horde/Core/actions/runs/7506946690/job/20439473685

ralflang
ralflang approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@ralflang ralflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better than re-inventing URL generation.
TODO for me: Check if we should use URL formatter from Horde\Url or Horde\Http\ instead.

@ralflang ralflang merged commit 24f4306 into horde:FRAMEWORK_6_0 Mar 28, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralflang ralflang ralflang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midahp @ralflang